[UEPR-67] restyle community guidelines page #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KManolov3
approved these changes
Oct 30, 2024
mxmou
reviewed
Nov 8, 2024
src/views/guidelines/guidelines.scss
Outdated
| background-position: left, right; | ||
| background-repeat: no-repeat; | ||
|
|
||
| border-top: 50px solid $ui-blue; |
There was a problem hiding this comment.
This blue strip looks weird. It's also there in the image in #5584, but I think it was most likely meant as a placeholder for the navigation bar (which was blue when the design was created).
There was a problem hiding this comment.
Thanks for pointing this. Tomorrow I will run it by Tif Gagnon to see what she would want to do with the stripe.
There was a problem hiding this comment.
We decided to remove the top border, thank you
KManolov3
changed the base branch from
develop
to
integration-branch-ux-12.2024
MiroslavDionisiev
merged commit ceefbbf
into
scratchfoundation:integration-branch-ux-12.2024
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket:
UEPR-67
Changes:
Updated styles of community guidelines page